-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore autoupdate for specific hook/s #1959
Comments
@asottile please help me with this ^^ |
if you don't want to auto update then don't run auto update you can use |
I think, I failed to explain importance. @asottile think about bot sending PR/MR to n number of projects and user just don't want update for specific hook/repo. |
you need to upgrade at some point |
Exactly, but sometimes project want to support like in my case py36 and mypi latest version creating problem. We need to take hard decision on this but need some time as ecosystem 😃. If pre-commit provide option to ignore autoupdate for specific hook just like pinning version then it will give freedom to users. It's just my opinion/Idea. |
I'm using latest mypy (you're spelling it wrong) with py36 just fine |
My bad. In mypy doc they provided awesome note.
|
that has nothing to do with python3.6 and if you want to restore all of typeshed without thinking about it see https://github.com/asottile/types-all |
Woot... intresting definitely this will solve problem 🙌. I would like to apply this with TODO note. |
I think that the ability to disable autoupdate for a specific hook entry is needed as I recently faced one such case with https://github.com/ansible/ansible-navigator/blob/main/.pre-commit-config.yaml#L224-L235 This repo has 15+ repos to update but one of the hooks cannot be updated because ones of flake8 extensions does not support flake 4.0 yet and I suspect it may take even 6 months for it to be updated. Updating ~15 hook versions by hand is no joy. What is even more interesting is that |
sorry but as above:
|
Take it as RFE or question
Recently,
mypi
latest version creating problems for my projects. I want to avoidmypi
hook inautoupdate
.Do we have anything which helps me to ignore just a specific hook and allow auto update for all other hooks as per YAML?
I think we can add one tag in yaml like
autoupdate=false
default pre-commit will consider autoupdate=true for all hooks.The text was updated successfully, but these errors were encountered: