prepare-commit-msg Not passing all parameters

[M-Whitaker]

search tried in the issue tracker

Yes

describe your issue

When I run git commit with certain arguments I expect to get two or more arguments passed to argv of my script as per the specification:

def main(argv, argc):
     print(argv, argc)

Will print

['tools/hooks/add-commit-template.py', '.git/COMMIT_EDITMSG'] 2

It looks to me from looking at your auto-created hook installed that you are passing all args to the script so it maybe I haven't configured this correctly.

Thanks

pre-commit --version

pre-commit 2.19.0

.pre-commit-config.yaml

repos:
   - repo:
     hooks:
        - id: commit-template-local
          name: Provide Commit Message Template
          entry: tools/hooks/add-commit-template.py
          language: python
          stages: [ prepare-commit-msg ]

~/.cache/pre-commit/pre-commit.log (if present)

No response

[asottile]

yep -- pre-commit is based on files -- for now the additional non-file arguments are discarded

there's precedent for other hook types to forward these arguments along (for example PRE_COMMIT_REMOTE_NAME for pre-push) -- it looks like these were just not implemented for prepare-commit-msg

please send a patch to add those if you'd like support for those as environment variables -- I'd grep around for PRE_COMMIT_REMOTE_NAME and follow the pattern used there

[M-Whitaker]

Ah, perfect I'm not going crazy. I'll have a look into this 🙂