Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port hook template to bash #2065

Merged
merged 1 commit into from Sep 27, 2021
Merged

port hook template to bash #2065

merged 1 commit into from Sep 27, 2021

Conversation

@asottile
Copy link
Member

@asottile asottile commented Sep 27, 2021

this avoids some version-specific code in python

this also makes the bootstrap script slightly more portable

closes #2045

this avoids some version-specific code in python

this also makes the bootstrap script slightly more portable
@asottile asottile merged commit b3c0d84 into master Sep 27, 2021
2 checks passed
@asottile asottile deleted the hook-template-bash branch Sep 27, 2021
R0ll1ngSt0ne
Copy link

R0ll1ngSt0ne commented on e622f79 Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile - I am curious as to the motivation of this change. Doesn't it effectively make pre-commit incompatible with Windows, which doesn't have bash?

asottile
Copy link
Member

asottile commented on e622f79 Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@R0ll1ngSt0ne git itself has parts implemented with bash so if you have git you have bash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants