Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIT_HTTP_PROXY_AUTHMETHOD kept in env variables #2272

Merged
merged 1 commit into from Mar 5, 2022

Conversation

VincentBerthier
Copy link
Contributor

@VincentBerthier VincentBerthier commented Mar 4, 2022

resolves #2271

@asottile
Copy link
Member

asottile commented Mar 4, 2022

cc @lorenzwalthert -- any ideas on the R failures here?

@lorenzwalthert
Copy link
Contributor

lorenzwalthert commented Mar 4, 2022

yes, a new version of the package {rlang} got released on CRAN. Since binaries take sometimes a few days to arrive, this CI run tried a source installation, and failed because of some system requirements for compiling code. The problem should go away in a few days. Alternative is to re-write the test to not involve a package like {rlang} that has system requirements as build time dependencies.

Maybe a more general solution that would also serve the user (instead of just hacking a test) would be to always prioritise binary packages over source package when initializing an environment, even if the source package offer a newer version, e.g. with options(install.packages.compile.from.source = "never")

@asottile
Copy link
Member

asottile commented Mar 5, 2022

yes, a new version of the package {rlang} got released on CRAN. Since binaries take sometimes a few days to arrive, this CI run tried a source installation, and failed because of some system requirements for compiling code. The problem should go away in a few days. Alternative is to re-write the test to not involve a package like {rlang} that has system requirements as build time dependencies.

Maybe a more general solution that would also serve the user (instead of just hacking a test) would be to always prioritise binary packages over source package when initializing an environment, even if the source package offer a newer version, e.g. with options(install.packages.compile.from.source = "never")

since you know way more about this -- could you help with a PR to add that?

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit d525928 into pre-commit:master Mar 5, 2022
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add GIT_HTTP_PROXY_AUTHMETHOD to kept environment variables
3 participants