coursier: Add support for both cs and coursier executable names
#2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Mar 17, 2022
pre_commit/languages/coursier.py
Outdated
| @@ -27,6 +27,14 @@ def install_environment( | |||
| helpers.assert_version_default('coursier', version) | |||
| helpers.assert_no_additional_deps('coursier', additional_dependencies) | |||
|
|
|||
| # Support both possible executable names (either "cs" or "coursier") | |||
| executable = next(filter(helpers.exe_exists, ('cs', 'coursier')), None) | |||
There was a problem hiding this comment.
unnecessary FP -- we avoid map / filter / reduce
this should be exe('cs') or exe('coursier') once you find the right function (helpers.exe_exists isn't it -- that returns a bool)
There was a problem hiding this comment.
this should be
exe('cs') or exe('coursier')once you find the right function (helpers.exe_existsisn't it -- that returns abool)
Do you want me to write a new one or is there something that I can use? shutil.which would be a candiate, or maybe pre_commit.parse_shebang.find_executable which kind of duplicates that functionality.
There was a problem hiding this comment.
find_executable is the right one probably yes
On some systems, the executable might be named `coursier` instead of `cs`. For example, this is the case on Arch Linux when using the AUR package, or when following the official instructions when installing the JAR-based launcher: https://get-coursier.io/docs/cli-installation#jar-based-launcher
Holzhaus
force-pushed
the
coursier-executable-names
branch
from
7846572
to
678ef6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, the executable might be named
coursierinstead ofcs. For example, this is the case on Arch Linux when using the AURpackage, or when following the official instructions when installing the
JAR-based launcher:
https://get-coursier.io/docs/cli-installation#jar-based-launcher