Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust relative --commit-msg-filename if in subdir #2459

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

asottile
Copy link
Member

No description provided.

@asottile
Copy link
Member Author

@lorenzwalthert any ideas for the windows R failure here?

@lorenzwalthert
Copy link
Contributor

lorenzwalthert commented Jul 12, 2022

Seems again related to missing built-time dependencies for source install, this time for transversive dependencies. Trying to enforce binary install with #2460.

@asottile
Copy link
Member Author

huh looks like I should have just clicked retry because it appears to be working now! thanks again for checking on this!

@asottile asottile merged commit c1e0836 into main Jul 23, 2022
@asottile asottile deleted the relative-commit-msg-filename branch July 23, 2022 20:49
@lorenzwalthert
Copy link
Contributor

Yeah, because the dependency (without version specification) was on a package that was not yet available as a binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants