Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
This is the big one!
Should resolve the following issues:
Some notable things:
Known breaking changes:
@chriskuehl and I have put a ton of work into this (my branch is roughly based on his prototype branch)
@Lucas-C is probably interested in this PR so... hi!
referenced this pull request
Jul 2, 2017
This looks really great -- much simpler than my original WIP branch (granted, the hard part of that was wrangling jsonschema...).
A couple thoughts:
- It might be useful to have pre-commit add a "submodule" tag at some point. Right now I suspect it's going to pass them to
identifywhich will call them
['directory']. That's definitely an improvement since it won't break hooks like it does now, but probably could be better. identify isn't in a good place to determine what is a submodule since it doesn't know about git.
- Probably worth mentioning
identify-cliwhen updating the docs, as it should be pretty helpful to folks figuring out what tags they can use.
Depending on how migrated repositories are, I'd suggest the following (at least temporary) if you plan to move repositories to use
if you still are maintaining