Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `check-useless-exclude` to consider types filter #837

Merged

Conversation

Projects
None yet
2 participants
@georgeyk
Copy link
Contributor

commented Oct 2, 2018

Fixes #704

@asottile
Copy link
Member

left a comment

Nice! This is great!

If you're looking for another starter issue this one has some code hints :)

@georgeyk

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2018

Thanks @asottile I'll take a look o/

@asottile asottile merged commit c0b1f2f into pre-commit:master Oct 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.