Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the webpack code splitting doc link #432

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@nuwanc
Copy link
Contributor

commented Sep 17, 2019

link to the working webpack code splitting link

@size-plugin

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Size report for the changes in this PR:

size-plugin-ssr Overall size: 208 kB (+34.6 kB 🚫)

 markdown.e0970.worker.js ⏤  0 B (-8.61 kB ✅)
    prism.28075.worker.js ⏤  0 B (-6.24 kB ✅)
    editor.chunk.*****.js ⏤  65.9 kB
     emoji.chunk.*****.js ⏤  8.83 kB
    runner.chunk.*****.js ⏤  5.86 kB
            ssr-bundle.js ⏤  28.6 kB (+992 B)
     repl.e198e.worker.js ⏤  0 B (-36.9 kB ✅)
   editor.chunk.7a736.css ⏤  3.17 kB
     ssr-bundle.06710.css ⏤  0 B (-10.9 kB ✅)
    prism.e82c3.worker.js ⏤  7.24 kB (+7.24 kB 🚫)
 markdown.c3d26.worker.js ⏤  9.56 kB (+9.56 kB 🚫)
     repl.51501.worker.js ⏤  68.5 kB (+68.5 kB 🚫)
     ssr-bundle.ac3c8.css ⏤  10.9 kB (+10.9 kB 🚫)

commit: e746946

@size-plugin

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Size report for the changes in this PR:

size-plugin-browser Overall size: 395 kB (+66.6 kB 🚫)

                 sw-esm.js ⏤  682 B
                     sw.js ⏤  678 B
  markdown.bc303.worker.js ⏤  0 B (-8.68 kB ✅)
     prism.18eb5.worker.js ⏤  0 B (-6.26 kB ✅)
  emoji.chunk.91398.esm.js ⏤  8.85 kB
    polyfills.6a525.esm.js ⏤  2.13 kB
  markdown.8ff2c.worker.js ⏤  0 B (-8.68 kB ✅)
      emoji.chunk.1ed91.js ⏤  8.85 kB
        polyfills.3233a.js ⏤  2.12 kB
      repl.0b7a0.worker.js ⏤  0 B (-34.9 kB ✅)
    editor.chunk.7a736.css ⏤  2.15 kB
 editor.chunk.fa6b3.esm.js ⏤  66.3 kB
 runner.chunk.a92f8.esm.js ⏤  0 B (-5.79 kB ✅)
         5.chunk.bc319.css ⏤  1.47 kB
      5.chunk.95a73.esm.js ⏤  3.39 kB
      repl.3f385.worker.js ⏤  0 B (-36.4 kB ✅)
     editor.chunk.e0251.js ⏤  66.4 kB
     runner.chunk.2df13.js ⏤  0 B (-5.83 kB ✅)
          5.chunk.b2018.js ⏤  3.45 kB
          bundle.c6f3d.css ⏤  9.11 kB
       bundle.01f9a.esm.js ⏤  0 B (-22.9 kB ✅)
           bundle.1e481.js ⏤  0 B (-23.2 kB ✅)
     prism.d329b.worker.js ⏤  7.32 kB (+7.32 kB 🚫)
  markdown.6af7e.worker.js ⏤  9.66 kB (+9.66 kB 🚫)
      repl.bfeb7.worker.js ⏤  66.7 kB (+66.7 kB 🚫)
       bundle.6ee5f.esm.js ⏤  22.9 kB (+22.9 kB 🚫)
 runner.chunk.097ea.esm.js ⏤  5.79 kB (+5.79 kB 🚫)
  markdown.d9ce1.worker.js ⏤  9.66 kB (+9.66 kB 🚫)
      repl.6e676.worker.js ⏤  68.1 kB (+68.1 kB 🚫)
           bundle.31633.js ⏤  23.2 kB (+23.2 kB 🚫)
     runner.chunk.50868.js ⏤  5.83 kB (+5.83 kB 🚫)

commit: e746946

Copy link
Member

left a comment

Awesome, thanks a bunch for your PR 👍💯

@marvinhagemeister marvinhagemeister merged commit 1d64e83 into preactjs:master Sep 18, 2019
5 of 6 checks passed
5 of 6 checks passed
Pages changed - preactjs 43 new files uploaded
Details
Header rules - preactjs 11 header rules processed
Details
Mixed content - preactjs No mixed content detected
Details
Redirect rules - preactjs 13 redirect rules processed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/preactjs/deploy-preview Deploy preview ready!
Details
@size-plugin size-plugin bot referenced this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.