From 19eaa947b19c2c388b30c96b9d9479c46d01e292 Mon Sep 17 00:00:00 2001 From: Andre Wiggins Date: Mon, 17 Feb 2020 00:08:46 -0800 Subject: [PATCH] Remove TODO comments --- src/diff/children.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/diff/children.js b/src/diff/children.js index 01fea85c15..772f0f50c9 100644 --- a/src/diff/children.js +++ b/src/diff/children.js @@ -140,7 +140,6 @@ export function diffChildren( // can clean up the property childVNode._nextDom = undefined; - // TODO: Investigate removing this `if` to save bytes if (oldVNode._newIndex != null) { oldChildren[oldVNode._newIndex] = undefined; } @@ -172,8 +171,8 @@ export function diffChildren( // Since this code path means oldVNode moved up in the tree, // remove oldVNode from oldChildren so that getDomSibling doesn't see it - // when searching for siblings - // TODO: Investigate removing this `if` to save bytes + // when searching for siblings. This mimics actually moving the DOM like + // insertBefore would do if (oldVNode._newIndex != null) { oldChildren[oldVNode._newIndex] = undefined; }