From 52ab905b4dee872a1485d70191bc34d23ea0ac1d Mon Sep 17 00:00:00 2001 From: Oleksii Rudenko Date: Sun, 11 Aug 2019 01:01:40 +0200 Subject: [PATCH] =?UTF-8?q?Remove=20a=20duplicate=20test=20in=20render=20t?= =?UTF-8?q?ests=20(and=20add=20additional=20chi=E2=80=A6=20(#1847)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove a duplicate test in render tests * Check childNodes in tests for falsy values --- test/browser/render.test.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/browser/render.test.js b/test/browser/render.test.js index 2dca499c4c..28f05225f6 100644 --- a/test/browser/render.test.js +++ b/test/browser/render.test.js @@ -44,12 +44,6 @@ describe('render()', () => { logCall(Element.prototype, 'remove'); }); - it('should render nothing node given null', () => { - render(null, scratch); - let c = scratch.childNodes; - expect(c).to.have.length(0); - }); - it('should render an empty text node given an empty string', () => { render('', scratch); let c = scratch.childNodes; @@ -163,21 +157,25 @@ describe('render()', () => { it('should not render null', () => { render(null, scratch); expect(scratch.innerHTML).to.equal(''); + expect(scratch.childNodes).to.have.length(0); }); it('should not render undefined', () => { render(undefined, scratch); expect(scratch.innerHTML).to.equal(''); + expect(scratch.childNodes).to.have.length(0); }); it('should not render boolean true', () => { render(true, scratch); expect(scratch.innerHTML).to.equal(''); + expect(scratch.childNodes).to.have.length(0); }); it('should not render boolean false', () => { render(false, scratch); expect(scratch.innerHTML).to.equal(''); + expect(scratch.childNodes).to.have.length(0); }); it('should not render children when using function children', () => {