Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preact@10.0.0-rc.3 + emotion/styled rendering issue #1952

Closed
animecyc opened this issue Sep 26, 2019 · 4 comments

Comments

@animecyc
Copy link

commented Sep 26, 2019

I'm testing a few internal libraries Preact X with Emotion styled-components and am running into an issue where the emotion styled components are not re-rendering as expected. Here is a code-sandbox replicating the issue: https://codesandbox.io/s/preact-x-emotion-lydz8?fontsize=14

@JoviDeCroock

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Hey, that should be resolved with the next release, this should work in rc.1 and we have fixed that in master

@animecyc

This comment has been minimized.

Copy link
Author

commented Sep 26, 2019

Thats great to hear. Was that fixed recently? Can you link me to the commit, curious as to what the issue/regression was.

@JoviDeCroock

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Here you go: #1931

@animecyc

This comment has been minimized.

Copy link
Author

commented Sep 26, 2019

Much appreciated! I'll close this down.

@animecyc animecyc closed this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.