Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) - event.persist should be a function, not an object #1498

Merged
merged 2 commits into from Apr 1, 2019

Conversation

@JoviDeCroock
Copy link
Member

JoviDeCroock commented Apr 1, 2019

According to: https://reactjs.org/docs/events.html#event-pooling
e.persist should be a function and not an object.

Fixes: #1497

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling fd4ef4f on fix/patchEventPersist into 11a35d1 on master.

Copy link
Member

marvinhagemeister left a comment

Wohoo, glad someone catched that 👍 💯

@JoviDeCroock JoviDeCroock changed the title (fix) - event should be a function, not an object (fix) - event.persist should be a function, not an object Apr 1, 2019
@jessicabyrne

This comment has been minimized.

Copy link
Contributor

jessicabyrne commented Apr 1, 2019

Awesome thanks for this fix! Any idea when it might be available in a release?

@marvinhagemeister

This comment has been minimized.

Copy link
Member

marvinhagemeister commented Apr 1, 2019

@jessicabyrne This will very likely be merged as soon as the CI is done 🎉 Our next release will be published tomorrow (~20-24h from now). I'm currently preparing the release notes as I'm writing this 🙂

@marvinhagemeister marvinhagemeister merged commit f4f385d into master Apr 1, 2019
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
security/snyk - package.json (developit) No manifest changes detected
@marvinhagemeister marvinhagemeister deleted the fix/patchEventPersist branch Apr 1, 2019
JoviDeCroock added a commit that referenced this pull request Apr 2, 2019
* master:
  (feat) - debugging effect hooks (#1495)
  (fix) - event.persist should be a function, not an object (#1498)

# Conflicts:
#	debug/src/debug.js
#	debug/test/browser/debug.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.