Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to silence opencollective message with environment variables #1911

Closed
wants to merge 1 commit into from

Conversation

@rettgerst
Copy link

commented Sep 4, 2019

whether or not you decide to remove the opencollective postinstall message, I think it's reasonable to request users' wishes not to see it.

this patch changes the script so that nothing is shown if the environment variables ADBLOCK, OPENCOLLECTIVE_HIDE or DISABLE_OPENCOLLECTIVE are set.

@coveralls

This comment has been minimized.

Copy link

commented Sep 4, 2019

Coverage Status

Coverage increased (+0.1%) to 99.881% when pulling 2d31677 on rettgerst:respect-adblock into 7345fe8 on preactjs:master.

@cristianbote

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Hey rett, we already considered removing it all together. Here #1904.
Thanks for opening it. I'll close yours and you can keep an eye on the first PR.

Thanks again for taking the time to open it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.