Improve ref typings for IntrinsicElements. #2070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the corresponding constructor type for all IntrinsicElements in JSX, improving
ref
types, for example the anchor tag now has the HTMLAnchorElement type in it'sref
.This was created with a simple JS script that extracts the constructor.name of every element in the
After running tests I spotted an issue with the
preact.tsx
test in thets
directory that wasn't detected previously due to the lack of typing in IntrinsicElements. A ref can be an Element or null, but that wasn't being considered in the types of the test.This is my first PR in here, I hope I'm not messing anything up 馃槃