Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict equality checks when comparing VNode type #2855

Merged
merged 1 commit into from Dec 1, 2020

Conversation

andrewiggins
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 30, 2020

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: faster ✔ 1% - 4% (1.06ms - 7.58ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -1% - +4% (-0.23ms - +1.36ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +12% (-1.39ms - +5.58ms)
    preact-local vs preact-master
  • text_update: faster ✔ 1% - 3% (0.03ms - 0.07ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: faster ✔ 0% - 0% (0.00ms - 0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: faster ✔ 0% - 0% (0.00ms - 0.00ms)
    preact-local vs preact-master
  • text_update: slower ❌ 0% - 0% (0.00ms - 0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 50
  • Built by: CI #547
  • Commit: 32b1eeb

duration

VersionAvg timevs preact-mastervs preact-local
preact-master180.31ms - 185.21ms-slower ❌
1% - 4%
1.06ms - 7.58ms
preact-local176.29ms - 180.59msfaster ✔
1% - 4%
1.06ms - 7.58ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.57ms - 3.57ms-slower ❌
0% - 0%
0.00ms - 0.01ms
preact-local3.56ms - 3.57msfaster ✔
0% - 0%
0.00ms - 0.01ms
-
03_update10th1k_x16
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 120
  • Built by: CI #547
  • Commit: 32b1eeb

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.94ms - 31.98ms-unsure 🔍
-4% - +1%
-1.36ms - +0.23ms
preact-local31.42ms - 32.64msunsure 🔍
-1% - +4%
-0.23ms - +1.36ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.51ms - 3.52ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.52ms - 3.52msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
many_updates
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 80
  • Built by: CI #547
  • Commit: 32b1eeb

duration

VersionAvg timevs preact-mastervs preact-local
preact-master44.92ms - 49.66ms-unsure 🔍
-11% - +3%
-5.58ms - +1.39ms
preact-local46.83ms - 51.94msunsure 🔍
-3% - +12%
-1.39ms - +5.58ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-slower ❌
0% - 0%
0.00ms - 0.00ms
preact-local4.85ms - 4.85msfaster ✔
0% - 0%
0.00ms - 0.00ms
-
text_update
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 50
  • Built by: CI #547
  • Commit: 32b1eeb

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.68ms - 2.71ms-slower ❌
1% - 3%
0.03ms - 0.07ms
preact-local2.63ms - 2.66msfaster ✔
1% - 3%
0.03ms - 0.07ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-faster ✔
0% - 0%
0.00ms - 0.00ms
preact-local0.82ms - 0.82msslower ❌
0% - 0%
0.00ms - 0.00ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

Size Change: +3 B (0%)

Total Size: 41.9 kB

Filename Size Change
dist/preact.js 4.02 kB +1 B
dist/preact.module.js 4.04 kB +1 B
dist/preact.umd.js 4.08 kB +1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.23 kB 0 B
compat/dist/compat.module.js 3.23 kB 0 B
compat/dist/compat.umd.js 3.28 kB 0 B
debug/dist/debug.js 3.12 kB 0 B
debug/dist/debug.module.js 3.11 kB 0 B
debug/dist/debug.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.min.js 4.04 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4e07e16 on strict-eq-type into f955cfc on master.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@marvinhagemeister marvinhagemeister merged commit 6bceb44 into master Dec 1, 2020
@marvinhagemeister marvinhagemeister deleted the strict-eq-type branch December 1, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants