Fix: Nested Suspended trees may be missing _children

[developit]

/cc @dvoytenko

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• 02_replace1k: unsure 🔍 -0% - +2% (-0.36ms - +3.01ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: unsure 🔍 -2% - +5% (-0.69ms - +2.13ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -1% - +1% (-24.10ms - +16.96ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -1% - +3% (-0.16ms - +0.61ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -1% - +3% (-2.12ms - +5.10ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -4% - +6% (-1.16ms - +1.66ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 -4% - +4% (-0.17ms - +0.16ms)
  ^{preact-local vs preact-master}

usedJSHeapSize

• 02_replace1k: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -1% - +1% (-0.05ms - +0.03ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-master}

Results

02_replace1k

• Browser: chrome-headless 93.0.4577.63
• Sample size: 80
• Built by: Benchmarks #454

• Commit: 2624d51

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	124.26ms - 126.52ms	-	unsure 🔍 -2% - +0% -3.01ms - +0.36ms
preact-local	125.47ms - 127.97ms	unsure 🔍 -0% - +2% -0.36ms - +3.01ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.42ms - 3.44ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.02ms
preact-local	3.41ms - 3.43ms	unsure 🔍 -0% - +0% -0.02ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-master	vs preact-local
preact-master	47.01ms - 47.96ms	-	unsure 🔍 -1% - +2% -0.31ms - +0.89ms
preact-local	46.83ms - 47.56ms	unsure 🔍 -2% - +1% -0.89ms - +0.31ms	-

run-warmup-1

Version	Avg time	vs preact-master	vs preact-local
preact-master	83.21ms - 85.29ms	-	unsure 🔍 -0% - +3% -0.32ms - +2.42ms
preact-local	82.32ms - 84.09ms	unsure 🔍 -3% - +0% -2.42ms - +0.32ms	-

run-warmup-2

Version	Avg time	vs preact-master	vs preact-local
preact-master	78.37ms - 85.86ms	-	unsure 🔍 -4% - +10% -2.70ms - +8.16ms
preact-local	75.46ms - 83.31ms	unsure 🔍 -10% - +3% -8.16ms - +2.70ms	-

run-warmup-3

Version	Avg time	vs preact-master	vs preact-local
preact-master	51.59ms - 57.53ms	-	unsure 🔍 -12% - +4% -6.71ms - +2.28ms
preact-local	53.40ms - 60.16ms	unsure 🔍 -4% - +12% -2.28ms - +6.71ms	-

run-warmup-4

Version	Avg time	vs preact-master	vs preact-local
preact-master	80.33ms - 82.93ms	-	unsure 🔍 -3% - +3% -2.24ms - +2.05ms
preact-local	80.01ms - 83.43ms	unsure 🔍 -3% - +3% -2.05ms - +2.24ms	-

run-final

Version	Avg time	vs preact-master	vs preact-local
preact-master	47.44ms - 49.47ms	-	unsure 🔍 -5% - +1% -2.34ms - +0.65ms
preact-local	48.20ms - 50.40ms	unsure 🔍 -1% - +5% -0.65ms - +2.34ms	-

03_update10th1k_x16

• Browser: chrome-headless 93.0.4577.63
• Sample size: 110
• Built by: Benchmarks #454

• Commit: 2624d51

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	41.59ms - 43.49ms	-	unsure 🔍 -5% - +2% -2.13ms - +0.69ms
preact-local	42.21ms - 44.30ms	unsure 🔍 -2% - +5% -0.69ms - +2.13ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.48ms - 3.49ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-local	3.48ms - 3.49ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

07_create10k

• Browser: chrome-headless 93.0.4577.63
• Sample size: 50
• Built by: Benchmarks #454

• Commit: 2624d51

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	1616.70ms - 1645.87ms	-	unsure 🔍 -1% - +1% -16.96ms - +24.10ms
preact-local	1613.26ms - 1642.17ms	unsure 🔍 -1% - +1% -24.10ms - +16.96ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	25.25ms - 25.25ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	25.25ms - 25.25ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter_list

• Browser: chrome-headless 93.0.4577.63
• Sample size: 50
• Built by: Benchmarks #454

• Commit: 2624d51

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	21.71ms - 22.24ms	-	unsure 🔍 -3% - +1% -0.61ms - +0.16ms
preact-local	21.92ms - 22.48ms	unsure 🔍 -1% - +3% -0.16ms - +0.61ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.47ms - 1.47ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	1.47ms - 1.47ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

• Browser: chrome-headless 93.0.4577.63
• Sample size: 50
• Built by: Benchmarks #454

• Commit: 2624d51

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	159.02ms - 164.80ms	-	unsure 🔍 -3% - +1% -5.10ms - +2.12ms
preact-local	161.23ms - 165.57ms	unsure 🔍 -1% - +3% -2.12ms - +5.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	6.01ms - 6.07ms	-	unsure 🔍 -1% - +1% -0.03ms - +0.05ms
preact-local	6.00ms - 6.06ms	unsure 🔍 -1% - +1% -0.05ms - +0.03ms	-

many_updates

• Browser: chrome-headless 93.0.4577.63
• Sample size: 80
• Built by: Benchmarks #454

• Commit: 2624d51

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	28.21ms - 30.18ms	-	unsure 🔍 -6% - +4% -1.66ms - +1.16ms
preact-local	28.44ms - 30.44ms	unsure 🔍 -4% - +6% -1.16ms - +1.66ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.54ms - 4.54ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	4.54ms - 4.54ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

text_update

• Browser: chrome-headless 93.0.4577.63
• Sample size: 70
• Built by: Benchmarks #454

• Commit: 2624d51

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.68ms - 3.92ms	-	unsure 🔍 -4% - +4% -0.16ms - +0.17ms
preact-local	3.69ms - 3.91ms	unsure 🔍 -4% - +4% -0.17ms - +0.16ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	0.72ms - 0.72ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	0.72ms - 0.72ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[coveralls]

Coverage increased (+0.001%) to 99.623% when pulling 2624d51 on bugfix-suspended-missing-children into fe3d375 on master.

[github-actions]

Size Change: -21 B (0%)

Total Size: 42 kB

Filename	Size	Change
dist/preact.js	3.96 kB	-5 B (0%)
dist/preact.min.js	3.98 kB	-5 B (0%)
dist/preact.module.js	3.98 kB	-6 B (0%)
dist/preact.umd.js	4.03 kB	-5 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
compat/dist/compat.js	3.41 kB	0 B
compat/dist/compat.module.js	3.4 kB	0 B
compat/dist/compat.umd.js	3.46 kB	0 B
debug/dist/debug.js	2.99 kB	0 B
debug/dist/debug.module.js	2.98 kB	0 B
debug/dist/debug.umd.js	3.07 kB	0 B
devtools/dist/devtools.js	232 B	0 B
devtools/dist/devtools.module.js	241 B	0 B
devtools/dist/devtools.umd.js	308 B	0 B
hooks/dist/hooks.js	1.13 kB	0 B
hooks/dist/hooks.module.js	1.15 kB	0 B
hooks/dist/hooks.umd.js	1.2 kB	0 B
jsx-runtime/dist/jsxRuntime.js	317 B	0 B
jsx-runtime/dist/jsxRuntime.module.js	327 B	0 B
jsx-runtime/dist/jsxRuntime.umd.js	395 B	0 B
test-utils/dist/testUtils.js	437 B	0 B
test-utils/dist/testUtils.module.js	439 B	0 B
test-utils/dist/testUtils.umd.js	515 B	0 B

_{compressed-size-action}

[dvoytenko]

Thanks for the quick fix!