Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix className leak #3279

Merged
merged 6 commits into from Nov 19, 2021
Merged

fix className leak #3279

merged 6 commits into from Nov 19, 2021

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Oct 8, 2021

Fixes #3159
Fixes #2582

I honestly think it's highly indeterministic to alter the props passed into a component, generally in React (compat) people will pas in either class or className and won't expect this to be changed. Introducing an additional prop is only going to confuse people. Note that we did not do this before

@coveralls
Copy link

@coveralls coveralls commented Oct 8, 2021

Coverage Status

Coverage remained the same at 99.624% when pulling 9be3898 on fix-class-leak into d744e24 on master.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 8, 2021

Size Change: 0 B

Total Size: 42 kB

Filename Size Change
compat/dist/compat.module.js 3.42 kB -1 B
compat/dist/compat.umd.js 3.49 kB +1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.44 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
dist/preact.js 3.96 kB 0 B
dist/preact.min.js 3.98 kB 0 B
dist/preact.module.js 3.98 kB 0 B
dist/preact.umd.js 4.03 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.14 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock deleted the fix-class-leak branch Oct 10, 2021
@JoviDeCroock JoviDeCroock restored the fix-class-leak branch Nov 15, 2021
@JoviDeCroock JoviDeCroock reopened this Nov 15, 2021
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Awesome 🙌

@JoviDeCroock JoviDeCroock merged commit 78f1518 into master Nov 19, 2021
4 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-class-leak branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants