Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support hydrating html comments #3327

Merged
merged 7 commits into from Nov 23, 2021
Merged

support hydrating html comments #3327

merged 7 commits into from Nov 23, 2021

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 15, 2021

fixes #3290

@github-actions
Copy link

@github-actions github-actions bot commented Nov 15, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +3% (-2.87ms - +3.93ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.75ms - +1.89ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -2% - +1% (-32.56ms - +16.32ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +7% (-0.24ms - +1.67ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -19% - +16% (-50.47ms - +43.54ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +2% (-1.68ms - +0.55ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +5% (-0.06ms - +0.20ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.02ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-0.04ms - +0.06ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master147.30ms - 151.74ms-unsure 🔍
-3% - +2%
-3.93ms - +2.87ms
preact-local147.47ms - 152.63msunsure 🔍
-2% - +3%
-2.87ms - +3.93ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.48ms - 3.49ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.48ms - 3.49msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master52.26ms - 53.93ms-unsure 🔍
-2% - +2%
-1.04ms - +1.19ms
preact-local52.28ms - 53.76msunsure 🔍
-2% - +2%
-1.19ms - +1.04ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master83.08ms - 86.16ms-unsure 🔍
-1% - +4%
-0.71ms - +3.21ms
preact-local82.16ms - 84.58msunsure 🔍
-4% - +1%
-3.21ms - +0.71ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master75.90ms - 82.27ms-unsure 🔍
-7% - +4%
-5.59ms - +3.18ms
preact-local77.27ms - 83.30msunsure 🔍
-4% - +7%
-3.18ms - +5.59ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master56.99ms - 63.36ms-unsure 🔍
-4% - +11%
-2.44ms - +6.21ms
preact-local55.37ms - 61.21msunsure 🔍
-10% - +4%
-6.21ms - +2.44ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master81.86ms - 85.26ms-unsure 🔍
-5% - +2%
-3.91ms - +1.69ms
preact-local82.44ms - 86.89msunsure 🔍
-2% - +5%
-1.69ms - +3.91ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master56.54ms - 58.46ms-unsure 🔍
-3% - +3%
-1.54ms - +1.45ms
preact-local56.40ms - 58.69msunsure 🔍
-3% - +3%
-1.45ms - +1.54ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master38.13ms - 40.55ms-unsure 🔍
-5% - +4%
-1.89ms - +1.75ms
preact-local38.06ms - 40.77msunsure 🔍
-4% - +5%
-1.75ms - +1.89ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.54ms - 3.56ms-unsure 🔍
-0% - +0%
-0.02ms - +0.01ms
preact-local3.55ms - 3.56msunsure 🔍
-0% - +0%
-0.01ms - +0.02ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1786.95ms - 1823.66ms-unsure 🔍
-1% - +2%
-16.32ms - +32.56ms
preact-local1781.05ms - 1813.31msunsure 🔍
-2% - +1%
-32.56ms - +16.32ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.32ms - 25.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.32ms - 25.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master24.10ms - 24.54ms-unsure 🔍
-7% - +1%
-1.67ms - +0.24ms
preact-local24.10ms - 25.96msunsure 🔍
-1% - +7%
-0.24ms - +1.67ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.54ms - 1.54ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.54ms - 1.54msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master227.09ms - 298.83ms-unsure 🔍
-17% - +20%
-43.54ms - +50.47ms
preact-local229.12ms - 289.87msunsure 🔍
-19% - +16%
-50.47ms - +43.54ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.15ms - 6.22ms-unsure 🔍
-1% - +1%
-0.06ms - +0.04ms
preact-local6.17ms - 6.23msunsure 🔍
-1% - +1%
-0.04ms - +0.06ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master34.24ms - 35.89ms-unsure 🔍
-2% - +5%
-0.55ms - +1.68ms
preact-local33.75ms - 35.25msunsure 🔍
-5% - +2%
-1.68ms - +0.55ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.61ms - 4.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.61ms - 4.61msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master4.02ms - 4.15ms-unsure 🔍
-5% - +1%
-0.20ms - +0.06ms
preact-local4.04ms - 4.27msunsure 🔍
-1% - +5%
-0.06ms - +0.20ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.78ms - 0.78ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.78ms - 0.78msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

@github-actions github-actions bot commented Nov 15, 2021

Size Change: +25 B (0%)

Total Size: 42.1 kB

Filename Size Change
dist/preact.js 3.97 kB +5 B (0%)
dist/preact.min.js 4 kB +10 B (0%)
dist/preact.module.js 3.99 kB +5 B (0%)
dist/preact.umd.js 4.03 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.44 kB 0 B
compat/dist/compat.module.js 3.42 kB 0 B
compat/dist/compat.umd.js 3.49 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.14 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

@coveralls coveralls commented Nov 15, 2021

Coverage Status

Coverage remained the same at 99.624% when pulling 539179b on hydrate-html-comments into 515e94b on master.

@JoviDeCroock JoviDeCroock merged commit 2c8365a into master Nov 23, 2021
12 checks passed
@JoviDeCroock JoviDeCroock deleted the hydrate-html-comments branch Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants