Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) - switch check for excessDomChildren #3342

Merged
merged 1 commit into from Nov 25, 2021
Merged

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 24, 2021

No description provided.

@github-actions
Copy link

@github-actions github-actions bot commented Nov 24, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +3% (-1.96ms - +3.40ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.70ms - +2.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +0% (-19.98ms - +7.47ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +3% (-0.41ms - +0.72ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -4% - +7% (-6.31ms - +12.19ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +2% (-1.23ms - +0.55ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -2% - +2% (-0.05ms - +0.06ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-0.03ms - +0.05ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master130.31ms - 133.71ms-unsure 🔍
-3% - +1%
-3.40ms - +1.96ms
preact-local130.66ms - 134.81msunsure 🔍
-1% - +3%
-1.96ms - +3.40ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.47ms - 3.48ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.47ms - 3.48msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master50.24ms - 51.53ms-unsure 🔍
-1% - +3%
-0.61ms - +1.44ms
preact-local49.68ms - 51.26msunsure 🔍
-3% - +1%
-1.44ms - +0.61ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master76.00ms - 78.61ms-unsure 🔍
-2% - +3%
-1.27ms - +2.66ms
preact-local75.14ms - 78.07msunsure 🔍
-3% - +2%
-2.66ms - +1.27ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master61.51ms - 69.53ms-unsure 🔍
-10% - +6%
-7.08ms - +3.77ms
preact-local63.51ms - 70.83msunsure 🔍
-6% - +11%
-3.77ms - +7.08ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master54.25ms - 61.78ms-unsure 🔍
-5% - +15%
-2.65ms - +8.04ms
preact-local51.53ms - 59.11msunsure 🔍
-14% - +4%
-8.04ms - +2.65ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master72.24ms - 75.68ms-unsure 🔍
-3% - +4%
-2.39ms - +2.81ms
preact-local71.80ms - 75.70msunsure 🔍
-4% - +3%
-2.81ms - +2.39ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master44.29ms - 47.27ms-unsure 🔍
-5% - +4%
-2.34ms - +2.01ms
preact-local44.36ms - 47.53msunsure 🔍
-4% - +5%
-2.01ms - +2.34ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master41.83ms - 44.44ms-unsure 🔍
-5% - +4%
-2.00ms - +1.70ms
preact-local41.97ms - 44.60msunsure 🔍
-4% - +5%
-1.70ms - +2.00ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.40ms - 3.40ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.39ms - 3.40msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1690.54ms - 1707.61ms-unsure 🔍
-0% - +1%
-7.47ms - +19.98ms
preact-local1682.07ms - 1703.57msunsure 🔍
-1% - +0%
-19.98ms - +7.47ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.32ms - 25.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.32ms - 25.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master27.48ms - 28.36ms-unsure 🔍
-3% - +1%
-0.72ms - +0.41ms
preact-local27.73ms - 28.43msunsure 🔍
-1% - +3%
-0.41ms - +0.72ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.54ms - 1.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.54ms - 1.55msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master168.55ms - 182.04ms-unsure 🔍
-7% - +4%
-12.19ms - +6.31ms
preact-local171.90ms - 184.56msunsure 🔍
-4% - +7%
-6.31ms - +12.19ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.14ms - 6.20ms-unsure 🔍
-1% - +1%
-0.05ms - +0.03ms
preact-local6.15ms - 6.21msunsure 🔍
-1% - +1%
-0.03ms - +0.05ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master26.63ms - 27.83ms-unsure 🔍
-2% - +5%
-0.55ms - +1.23ms
preact-local26.23ms - 27.55msunsure 🔍
-5% - +2%
-1.23ms - +0.55ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.61ms - 4.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.61ms - 4.61msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.85ms - 2.93ms-unsure 🔍
-2% - +2%
-0.06ms - +0.05ms
preact-local2.86ms - 2.94msunsure 🔍
-2% - +2%
-0.05ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.78ms - 0.78ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.78ms - 0.78msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

@coveralls coveralls commented Nov 24, 2021

Coverage Status

Coverage remained the same at 99.624% when pulling 1c36c77 on fix-ie11-hydrate into 278e48f on master.

@github-actions
Copy link

@github-actions github-actions bot commented Nov 24, 2021

Size Change: +3 B (0%)

Total Size: 42.1 kB

Filename Size Change
dist/preact.min.js 4 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.44 kB 0 B
compat/dist/compat.module.js 3.42 kB 0 B
compat/dist/compat.umd.js 3.49 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
dist/preact.js 3.97 kB 0 B
dist/preact.module.js 3.99 kB 0 B
dist/preact.umd.js 4.03 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.14 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 12c7408 into master Nov 25, 2021
12 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-ie11-hydrate branch Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants