New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubmatic destroys bid sizes #3111

Closed
ReinoutStevens opened this Issue Sep 20, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@ReinoutStevens

ReinoutStevens commented Sep 20, 2018

Type of issue

Bug

Description

Since Prebid 1.18 Pubmatic supports multi-size adslots ( #2887 ). When passing an adslot without '@widthxheight' the sizes of the mediatypes.banner.sizes is used. Pubmatic bid adapter destructively modifies this array, messing up other adapters (in our case ixBidAdapter).

The offending line is L266

When you pass @widthxheight in adslot sizes is removed on L120, which may also be an issue of the object is shared across different adapters.

Also note that the first size is ignored for some reason due to the splice call. This is probably due to the first size already being taken on L122.

Steps to reproduce

Have a pubmatic bid without the size defined in the adslot name.

Test page

http://jsfiddle.net/2qwfp0zh/

Expected results

Index bidAdapter should not complain

Actual results

Index bidAdapter is a sad panda because the sizes are messed up

@pm-harshad-mane

This comment has been minimized.

Show comment
Hide comment
@pm-harshad-mane

pm-harshad-mane Sep 21, 2018

Contributor

Hello @ReinoutStevens ,

Thank you for informing.
We (PubMatic) are looking into it.

Contributor

pm-harshad-mane commented Sep 21, 2018

Hello @ReinoutStevens ,

Thank you for informing.
We (PubMatic) are looking into it.

@jsnellbaker jsnellbaker added the bug label Sep 24, 2018

@pm-harshad-mane pm-harshad-mane referenced this issue Sep 24, 2018

Merged

Bugfix: Issue 3111 #3122

1 of 1 task complete
@jsnellbaker

This comment has been minimized.

Show comment
Hide comment
@jsnellbaker

jsnellbaker Sep 26, 2018

Collaborator

This particular issue has been fixed at the adapter level; I will open a new issue for a fix at the core level to avoid this issue happening again accidentally with other adatpers.

Collaborator

jsnellbaker commented Sep 26, 2018

This particular issue has been fixed at the adapter level; I will open a new issue for a fix at the core level to avoid this issue happening again accidentally with other adatpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment