New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video support for AdKernel adapter #1270

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
5 participants
@ckbo3hrk
Contributor

ckbo3hrk commented Jun 6, 2017

Type of change

  • Feature

Description of change

Video support for AdKernel adapter has been added.

  • Test parameters for validating bids
{ 
  code: 'video_wrapper',
  sizes: [640, 480],
  mediaType : 'video',
  bids: [{ bidder: 'adkernel',
       params: {
           zoneId : '30164',
           host : 'cpm.metaadserving.com'}
  }]
}

@ckbo3hrk ckbo3hrk closed this Jun 6, 2017

@ckbo3hrk ckbo3hrk reopened this Jun 6, 2017

@mjacobsonny mjacobsonny added the video label Jun 6, 2017

@matthewlane matthewlane self-assigned this Jun 15, 2017

@matthewlane

Thanks for the video PR. One comment for review, and do you have test parameters we can use for validating bid responses with this change?

width: width,
height: height,
cpm: parseFloat(resp.price)
});
if (bid.params.video) {
bidObj.vastUrl = resp.nurl;

This comment has been minimized.

@matthewlane

matthewlane Jun 19, 2017

Collaborator

Please also signify this is a video bid response with bidObj.mediaType = 'video';, and you may want to add bidObj.descriptionUrl = resp.nurl;, which is used in pbjs.buildMasterVideoTagFromAdserverTag (edit: descriptionUrl isn't required)

@matthewlane

This comment has been minimized.

Collaborator

matthewlane commented Jul 11, 2017

@ckbo3hrk Please resolve conflicts and see note about adding bidObj.mediaType = 'video'; to help us the merge, thanks

@ckbo3hrk

This comment has been minimized.

Contributor

ckbo3hrk commented Jul 13, 2017

@matthewlane Everything is done. Also there are the test parameters you've asked for :

{ 
  code: 'video_wrapper',
  sizes: [640, 480],
  mediaType : 'video',
  bids: [{ bidder: 'adkernel',
       params: {
           zoneId : '30164',
           host : 'cpm.metaadserving.com'}
  }]
}

@mkendall07 mkendall07 added the LGTM label Jul 13, 2017

@dbemiller dbemiller merged commit 7d53893 into prebid:master Jul 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jbAdyoulike added a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017

@ckbo3hrk ckbo3hrk deleted the ckbo3hrk:adkernel_video branch Dec 12, 2017

dluxemburg added a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment