Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Audience Network: Add support for video format #1292
Type of change
Description of change
Hello, this PR adds support for the
Code looks generally fine. One line will cause some issues and needs fixing.
Can you send me some bid params so I can test it?
@lovell Sorry for the delay. It turns out that someone on our team already had an app set up.
I don't know about Facebook's internal ad setup... but do we need a separate placement ID for different media types?
If not, we can reuse
@wheresbarney I'm getting a bid... but it doesn't look valid.
Video bids should have a
My full test page is below. Loaded on chrome while logged into facebook, with dev tools emulating a mobile device.