New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPM value as parameter for Vertoz Adapter #1306

Merged
merged 4 commits into from Jul 17, 2017

Conversation

Projects
None yet
6 participants
@Prebid-Vertoz
Contributor

Prebid-Vertoz commented Jun 19, 2017

Type of change

  • [x ] Other

Description of change

Addition of CPM value as a parameter in Vertoz Adapter.

Other information

@Prebid-Vertoz

This comment has been minimized.

Contributor

Prebid-Vertoz commented Jul 14, 2017

Hi team,

Just to ensure, is anything more needs to be done from our side?

@mkendall07

This comment has been minimized.

Collaborator

mkendall07 commented Jul 14, 2017

@Prebid-Vertoz
Please rebase off master as the adapters are now under /modules instead of /src/adapters

@Prebid-Vertoz

This comment has been minimized.

Contributor

Prebid-Vertoz commented Jul 17, 2017

@mkendall07 Thanks for your reply.
I have done changes now.

@@ -20,6 +20,7 @@ function VertozAdapter() {
let vzEndPoint = BASE_URI;
let reqParams = bid.params || {};
let placementId = utils.getValue(reqParams, 'placementId');
let cpm = utils.getValue(reqParams, 'cpm');

This comment has been minimized.

@mkendall07

mkendall07 Jul 17, 2017

Collaborator

what is cpm suppose to represent? Is this a floor?

This comment has been minimized.

@Prebid-Vertoz

Prebid-Vertoz Jul 17, 2017

Contributor

Yes, it is a floor.

This comment has been minimized.

@mkendall07

mkendall07 Jul 17, 2017

Collaborator

can you rename it to cpmFloor or similar than?

This comment has been minimized.

@Prebid-Vertoz

Prebid-Vertoz Jul 17, 2017

Contributor

Hi @mkendall07 , renamed cpm to cpmFloor.

@mkendall07 mkendall07 merged commit 2c8ec16 into prebid:master Jul 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mkendall07

This comment has been minimized.

Collaborator

mkendall07 commented Jul 17, 2017

this is merged. Please update the documentation page as well. Thanks

@Prebid-Vertoz

This comment has been minimized.

Contributor

Prebid-Vertoz commented Jul 21, 2017

Hi @mkendall07 we have updated documentation page for this change and placed a pull request.
But we could not see our change reflected when we downloaded prebid.js from download page with only vertoz adapter selected.

@mkendall07

This comment has been minimized.

Collaborator

mkendall07 commented Jul 21, 2017

It will be released next week when we update the download page.

outoftime added a commit to Genius/Prebid.js that referenced this pull request Jul 28, 2017

Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…
…built

* 'master' of https://github.com/prebid/Prebid.js: (95 commits)
  Specify --browsers when using gulp test --watch (prebid#1420)
  Added aliases for aol adapter. (prebid#1371)
  Added MobFox Adapter (prebid#1312)
  Fixed style error. (prebid#1419)
  Add native support for Criteo adapter (prebid#999)
  Update admediaBidAdapter.js (prebid#1395)
  Increment pre version (prebid#1413)
  Prebid 0.26.1 Release (prebid#1412)
  fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411)
  Lint modules directory (prebid#1404)
  Set outstream mediaType based on renderer in response (prebid#1391)
  Fixing the BidAdjustmentEvent fire time (prebid#1399)
  Fix banner showing up in prebid-core.js (prebid#1388)
  Mention NodeJS 4.0 dependency in the README (prebid#1386)
  Increment pre version (prebid#1385)
  Prebid 0.26.0 Release (prebid#1384)
  PulsePoint Lite adapter - adding createNew method for aliasing. (prebid#1383)
  Modernizing build dependencies (prebid#1355)
  StickyAdsTV bidder adapter update (prebid#1311)
  Added CPM value as parameter for Vertoz Adapter (prebid#1306)
  ...
@Prebid-Vertoz

This comment has been minimized.

Contributor

Prebid-Vertoz commented Aug 1, 2017

Hi @mkendall07 , is that download page updated. Actually we still can not see our change reflected when we downloaded prebid.js with vertoz adapter.

@Prebid-Vertoz

This comment has been minimized.

Contributor

Prebid-Vertoz commented Aug 8, 2017

Hi @mkendall07 , any update on this?

jbAdyoulike added a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017

Added CPM value as parameter for Vertoz Adapter (prebid#1306)
* Added CPM for user input

* changed variable name from cpm to cpmFloor

dluxemburg added a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018

Added CPM value as parameter for Vertoz Adapter (prebid#1306)
* Added CPM for user input

* changed variable name from cpm to cpmFloor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment