New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate unit tests by stubbing calls to external lib #1308

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
5 participants
@Swiiip
Contributor

Swiiip commented Jun 19, 2017

This should fix #1226

Type of change

  • [x ] Bugfix
  • [x ] CI related changes

Description of change

Isolate unit tests by stubbing calls to external lib

@dbemiller

Thanks for taking care of this!

One minor change needed before we can merge it.

import {expect} from 'chai';
var CONSTANTS = require('../../../src/constants');
/* ------------ Publishertag stub begin ------------ */
window.Criteo = {

This comment has been minimized.

@dbemiller

dbemiller Jun 20, 2017

Contributor

Test preconditions should be in a before or beforeEach block, as appropriate. See https://mochajs.org/#hooks

This comment has been minimized.

@Swiiip

Swiiip Jun 21, 2017

Contributor

Done !

@dbemiller dbemiller added needs update and removed needs review labels Jun 20, 2017

@dbemiller dbemiller added LGTM and removed needs update labels Jun 21, 2017

@mkendall07 mkendall07 merged commit a3c8e10 into prebid:master Jun 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grevory

This comment has been minimized.

Contributor

grevory commented Jun 22, 2017

Fantastic! Thank you.

@dbemiller dbemiller referenced this pull request Jun 22, 2017

Merged

Kargo adapter #1316

2 of 9 tasks complete

Yann-Pravo added a commit to Yann-Pravo/Prebid.js that referenced this pull request Jul 6, 2017

jbAdyoulike added a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017

dluxemburg added a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment