Mention NodeJS 4.0 dependency in the README #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused me some trouble on a Debian Jessie machine (which ships with NodeJS 0.10).
|
Thanks for the PR. This probably happened during #1355, where I definitely overlooked node compatibility. Could you also add an |
|
Of course! Didn't know that option existed, thanks! |
dbemiller
previously approved these changes
Jul 18, 2017
|
There is actually a mention of node 4.0 here already at the bottom of this portion: https://github.com/prebid/Prebid.js/blob/master/README.md#Build |
|
Ah, missed that one. I moved and changed the note. 'npm install' aborts with a lot of errors on NodeJS < 4.0, it's not just needed for 'gulp' |
dbemiller
approved these changes
Jul 18, 2017
mkendall07
approved these changes
Jul 18, 2017
|
thanks! |
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 28, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (95 commits) Specify --browsers when using gulp test --watch (prebid#1420) Added aliases for aol adapter. (prebid#1371) Added MobFox Adapter (prebid#1312) Fixed style error. (prebid#1419) Add native support for Criteo adapter (prebid#999) Update admediaBidAdapter.js (prebid#1395) Increment pre version (prebid#1413) Prebid 0.26.1 Release (prebid#1412) fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411) Lint modules directory (prebid#1404) Set outstream mediaType based on renderer in response (prebid#1391) Fixing the BidAdjustmentEvent fire time (prebid#1399) Fix banner showing up in prebid-core.js (prebid#1388) Mention NodeJS 4.0 dependency in the README (prebid#1386) Increment pre version (prebid#1385) Prebid 0.26.0 Release (prebid#1384) PulsePoint Lite adapter - adding createNew method for aliasing. (prebid#1383) Modernizing build dependencies (prebid#1355) StickyAdsTV bidder adapter update (prebid#1311) Added CPM value as parameter for Vertoz Adapter (prebid#1306) ...
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Mention NodeJS 4.0 dependency in the README This caused me some trouble on a Debian Jessie machine (which ships with NodeJS 0.10). * Require NodeJS => 4.0 * (re)move note about NodeJS
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Mention NodeJS 4.0 dependency in the README This caused me some trouble on a Debian Jessie machine (which ships with NodeJS 0.10). * Require NodeJS => 4.0 * (re)move note about NodeJS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused me some trouble on a Debian Jessie machine (which ships with NodeJS 0.10).