-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update logic of ad_types field in appnexusBidAdapter #4065
Conversation
placing on hold for now due to some concerns about multi format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on hold
@mkendall07 Per the internal feedback, this change should be good to implement. Can you take another look when you have the chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey all, When I define adUnits without mediaTypes I get a parsing error returned, it looks like it's related to missing sizes in the request payload to AppNexus. I think sizes must still be defined and sent over to avoid the parse error. Check out my Fiddle for a working example - http://jsfiddle.net/nfm0ahbk/2/. |
Type of change
Description of change
This PR changes how the
ad_types
field of the appnexus request is populated in relation to banner media type.Previously the field was populated automatically with
'banner'
if themediaType(s)
field of the bid object was empty or if either of those fields were set tobanner
. The latter case actually always happened since Prebid.js treats any adUnit request without a definedmediaTypes
object asbanner
and creates amediaTypes
field in the bid with a banner object in this scenario.Now with this change, the
banner
ad_type
is only populated if the originaladUnit
contained amediaTypes.banner
object. If theadUnit.mediaTypes
object is missing, then the field is left out of the appnexus request. In terms of the delivery decision for the bid, this scenario would defer to the types that are setup within the placement and use that to choose the type of bid to find/return.