Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting Clicktripz bid adapter #4929

Merged
merged 5 commits into from Mar 12, 2020
Merged

Submitting Clicktripz bid adapter #4929

merged 5 commits into from Mar 12, 2020

Conversation

@apmitchell
Copy link
Contributor

apmitchell commented Mar 4, 2020

Type of change

  • New bidder adapter

Description of change

Submitting Clicktripz bidder adapter for acceptance into the prebid.js repo.
Includes:

  1. adapter
  2. description
  3. test
  • test parameters for validating bids
{
    bidder: "clicktripz",
    params: {
        placementId: '4312c63f',
        siteId: 'prebid',
    }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

- adapter
- description
- test
@harpere harpere requested a review from bx2 Mar 5, 2020
@apmitchell

This comment has been minimized.

Copy link
Contributor Author

apmitchell commented Mar 10, 2020

Hi @bx2, I see this PR has a needs docs label. Is there something I need to do or am I waiting on your review?

@bx2

This comment has been minimized.

Copy link
Collaborator

bx2 commented Mar 11, 2020

@apmitchell

I will try to finish the review today.

In the meantime, the "needs-docs" label means that you are still to submit a MR with your bidder documentation. Take a look at https://prebid.org/dev-docs/bidder-adaptor.html at the very bottom:

1. Fork the repo prebid.github.io
2. Copy a file in dev-docs/bidders and modify
Copy link
Collaborator

bx2 left a comment

Thanks for you patience. You will find my comments below. Additionally, please:

  1. Fix the linting issue in the code:
Prebid.js/test/spec/modules/clicktripzBidAdapter_spec.js
  2:20  error  Missing file extension "js" for "modules/clicktripzBidAdapter"  import/extension
  1. Do not modify our packages.lock with this MR. If for some reason you think this file should be updated, please submit it as a separate MR as changes you added there do not influence operations of the adapter.
modules/clicktripzBidAdapter.md Outdated Show resolved Hide resolved
modules/clicktripzBidAdapter.md Outdated Show resolved Hide resolved
modules/clicktripzBidAdapter.js Outdated Show resolved Hide resolved
modules/clicktripzBidAdapter.js Outdated Show resolved Hide resolved
modules/clicktripzBidAdapter.js Outdated Show resolved Hide resolved
@apmitchell

This comment has been minimized.

Copy link
Contributor Author

apmitchell commented Mar 11, 2020

@apmitchell

I will try to finish the review today.

In the meantime, the "needs-docs" label means that you are still to submit a MR with your bidder documentation. Take a look at https://prebid.org/dev-docs/bidder-adaptor.html at the very bottom:

1. Fork the repo prebid.github.io
2. Copy a file in dev-docs/bidders and modify

Hi @bx2, I have that MR here prebid/prebid.github.io#1836

apmitchell added 4 commits Mar 11, 2020
- imports _each from ../src/utils.js
- replace use of .forEach with _each
- log entire error, removes loop
- splits size once
- fix typo in documentation file
- fix linter erro in test file
@bx2 bx2 removed the needs docs label Mar 12, 2020
@bx2
bx2 approved these changes Mar 12, 2020
@bx2 bx2 added LGTM and removed needs review labels Mar 12, 2020
@bx2 bx2 merged commit 703b898 into prebid:master Mar 12, 2020
2 checks passed
2 checks passed
LGTM analysis: JavaScript No new or fixed alerts
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@bx2

This comment has been minimized.

Copy link
Collaborator

bx2 commented Mar 12, 2020

@apmitchell thanks for you patience. I reviewed and accepted the changes you submitted. They will be available in the next release of Prebid.

You may open a PR in the headerbid-expert repository to have your adapter recognized by the Headerbid Expert extension. The PR should be to the bidder patterns file, adding an entry with your adapter's name and the url the adapter uses to send and receive bid responses.

redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
* master: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
Clicktripz bid adapter
- adapter
- description
- test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.