Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP data-multi-size should not replace original size #827

Closed
dlackty opened this issue Mar 6, 2019 · 3 comments · Fixed by #1352
Closed

AMP data-multi-size should not replace original size #827

dlackty opened this issue Mar 6, 2019 · 3 comments · Fixed by #1352

Comments

@dlackty
Copy link
Contributor

dlackty commented Mar 6, 2019

Let's take a look at sample <amp-ad> tag from official doc:

<amp-ad width=728 height=90
    type="doubleclick"
    layout="fixed"
    data-slot="/6355419/Travel"
    data-multi-size="700x90,700x60,500x60">
</amp-ad>

It should request 700x90,700x60,500x60 (data-multi-size) along with 728x90 (width / heigh).

Current implementation will just return parsed result of data-multi-size.

} else if parsedSizes := parseMultisize(multisize); len(parsedSizes) != 0 {
return parsedSizes
} else if width != 0 && height != 0 {
return []openrtb.Format{{
W: width,
H: height,
}}

@stale
Copy link

stale bot commented Aug 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 8, 2019
@dlackty
Copy link
Contributor Author

dlackty commented Aug 8, 2019

I think this problem hasn't been resolved yet? However, prebid/prebid-server-java#314 solved this problem in Java implementation.

@stale stale bot removed the stale label Aug 8, 2019
@stale
Copy link

stale bot commented Aug 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants