Add comments on HTML injection in index #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So to clarify why it does not contain any reference to bundled scripts nor styles.
Member
|
This PR is a no for me. We don't need those comments in there and they will remain on production for no good reason. |
Collaborator
|
I agree that we shouldn't add comments to the index, but maybe we could add a note in the readme file ? |
Member
|
I can do that. |
Contributor
Author
|
that's fine |
rfonascimento
pushed a commit
to rfonascimento/trackiii
that referenced
this pull request
Feb 19, 2018
rfonascimento
pushed a commit
to rfonascimento/trackiii
that referenced
this pull request
Feb 19, 2018
sumile-ting
pushed a commit
to sumile-ting/angular-adminlte
that referenced
this pull request
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So to clarify why it does not contain any reference to bundled scripts nor styles.