Skip to content

Conversation

@McGiogen
Copy link

@McGiogen McGiogen commented Sep 6, 2016

Fixes #51 .

@McGiogen McGiogen changed the title Fixes #51 - Replace isparta loader with babel-plugin-istanbul Fixes #51 - Replace isparta-loader with babel-plugin-istanbul Sep 6, 2016
@matthamil
Copy link

matthamil commented Sep 7, 2016

I get the following error when trying to run npm test for your PR locally:

npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/matthamil/.nvm/versions/node/v6.4.0/bin/node" "/Users/matthamil/.nvm/versions/node/v6.4.0/bin/npm" "run" "test"
npm ERR! node v6.4.0
npm ERR! npm  v3.10.3
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! angular-webpack-workflow@1.0.0 test: `cross-env NODE_ENV=test karma start`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the angular-webpack-workflow@1.0.0 test script 'cross-env NODE_ENV=test karma start'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-webpack-workflow package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     cross-env NODE_ENV=test karma start
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-webpack-workflow
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-webpack-workflow
npm ERR! There is likely additional logging output above.

Trying to use this repo to get testing configured with an Angular 1.x and Webpack project.

@McGiogen
Copy link
Author

McGiogen commented Sep 8, 2016

Are you using Windows? I've deleted all my global npm packages, cloned my repo and reinstalled all npm packages to have a clean environment and it's working like a charm. But I'm on linux, Xubuntu 16.04.

Update: on Windows it is working but coverage summary lists "0/0" on every line... I don't know why

@matthamil
Copy link

Somehow I managed to clone it down incorrectly. It works fine now. I'm running OSX El Capitan.

@McGiogen McGiogen force-pushed the 51-babel-plugin-istanbul branch from b1cd8d0 to 32a13b4 Compare September 19, 2016 15:44
@McGiogen
Copy link
Author

Code update: removed cross-env dependency, moved babel configuration to webpack.config.js

@phra
Copy link
Member

phra commented Nov 23, 2016

i'm closing this in favor of #53

@phra phra closed this Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants