We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following functions are not really useful anymore:
precice/src/precice/Constants.hpp
Lines 9 to 13 in e480aef
We can get rid of them. Don't forget to also remove them in the bindings.
The text was updated successfully, but these errors were encountered:
I would actually go one step further and remove Contants.hpp completely.
Contants.hpp
Lines 15 to 18 in e480aef
... could be moved to SolverInterface or we replace them by better solutions
SolverInterface
Lines 20 to 21 in e480aef
... I don't know what this is for
Sorry, something went wrong.
I think nobody uses actionPlotOutput
actionPlotOutput
I tried to remove it, but then I got into trouble:
[ 65%] Linking CXX executable binprecice libprecice.a(SolverInterfaceImpl.cpp.o): In function `precice::impl::SolverInterfaceImpl::initializeData()': /home/benjamin/precice/src/precice/impl/SolverInterfaceImpl.cpp:321: undefined reference to `precice::constants::actionPlotOutput[abi:cxx11]()' libprecice.a(SolverInterfaceImpl.cpp.o): In function `precice::impl::SolverInterfaceImpl::finalize()': /home/benjamin/precice/src/precice/impl/SolverInterfaceImpl.cpp:442: undefined reference to `precice::constants::actionPlotOutput[abi:cxx11]()' libprecice.a(SolverInterfaceImpl.cpp.o): In function `precice::impl::SolverInterfaceImpl::handleExports()': /home/benjamin/precice/src/precice/impl/SolverInterfaceImpl.cpp:1540: undefined reference to `precice::constants::actionPlotOutput[abi:cxx11]()' collect2: error: ld returned 1 exit status CMakeFiles/binprecice.dir/build.make:244: recipe for target 'binprecice' failed make[2]: *** [binprecice] Error 1 CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/binprecice.dir/all' failed make[1]: *** [CMakeFiles/binprecice.dir/all] Error 2 Makefile:162: recipe for target 'all' failed make: *** [all] Error 2
BenjaminRodenberg
Successfully merging a pull request may close this issue.
The following functions are not really useful anymore:
precice/src/precice/Constants.hpp
Lines 9 to 13 in e480aef
We can get rid of them. Don't forget to also remove them in the bindings.
The text was updated successfully, but these errors were encountered: