Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of outdated functions in Constants.* #365

Closed
BenjaminRodenberg opened this issue Apr 24, 2019 · 3 comments · Fixed by #395
Closed

Get rid of outdated functions in Constants.* #365

BenjaminRodenberg opened this issue Apr 24, 2019 · 3 comments · Fixed by #395
Assignees
Labels
good first issue Everybody is invited to help: students, users, externals, ...
Milestone

Comments

@BenjaminRodenberg
Copy link
Member

The following functions are not really useful anymore:

const std::string& nameConfiguration();
const std::string& dataDisplacements();
const std::string& dataForces();
const std::string& dataVelocities();

We can get rid of them. Don't forget to also remove them in the bindings.

@BenjaminRodenberg BenjaminRodenberg added the good first issue Everybody is invited to help: students, users, externals, ... label Apr 24, 2019
@BenjaminRodenberg BenjaminRodenberg added this to the Version 1.5.0 milestone Apr 24, 2019
@uekerman
Copy link
Member

I would actually go one step further and remove Contants.hpp completely.

const std::string& actionWriteInitialData();
const std::string& actionWriteIterationCheckpoint();
const std::string& actionReadIterationCheckpoint();
const std::string& actionPlotOutput();

... could be moved to SolverInterface or we replace them by better solutions

int exportVTK();
int exportAll();

... I don't know what this is for

@uekerman
Copy link
Member

I think nobody uses actionPlotOutput

@BenjaminRodenberg BenjaminRodenberg self-assigned this May 20, 2019
@BenjaminRodenberg
Copy link
Member Author

I think nobody uses actionPlotOutput

I tried to remove it, but then I got into trouble:

[ 65%] Linking CXX executable binprecice
libprecice.a(SolverInterfaceImpl.cpp.o): In function `precice::impl::SolverInterfaceImpl::initializeData()':
/home/benjamin/precice/src/precice/impl/SolverInterfaceImpl.cpp:321: undefined reference to `precice::constants::actionPlotOutput[abi:cxx11]()'
libprecice.a(SolverInterfaceImpl.cpp.o): In function `precice::impl::SolverInterfaceImpl::finalize()':
/home/benjamin/precice/src/precice/impl/SolverInterfaceImpl.cpp:442: undefined reference to `precice::constants::actionPlotOutput[abi:cxx11]()'
libprecice.a(SolverInterfaceImpl.cpp.o): In function `precice::impl::SolverInterfaceImpl::handleExports()':
/home/benjamin/precice/src/precice/impl/SolverInterfaceImpl.cpp:1540: undefined reference to `precice::constants::actionPlotOutput[abi:cxx11]()'
collect2: error: ld returned 1 exit status
CMakeFiles/binprecice.dir/build.make:244: recipe for target 'binprecice' failed
make[2]: *** [binprecice] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/binprecice.dir/all' failed
make[1]: *** [CMakeFiles/binprecice.dir/all] Error 2
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everybody is invited to help: students, users, externals, ...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants