Skip to content

Conversation

@davidscn
Copy link
Member

@davidscn davidscn commented Feb 2, 2022

I received a message on discourse pointing out that our hint for the ´residualControl` for OpenFOAM foundation versions is actually not correct. I added a note here and also a link to the corresponding OpenFOAM bug.

@davidscn davidscn requested a review from MakisH February 2, 2022 08:35
@MakisH MakisH changed the title Fix note regarding OpenFAOM and residual control Fix note regarding OpenFOAM and residual control Feb 2, 2022
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specific reference:

... Note that existing PIMPLE "residualControl" entries will need to be
renamed "outerCorrectorResidualControl".

The commit has tags pointing to OpenFOAM6 and newer, so we don't need the "probably"

@davidscn
Copy link
Member Author

davidscn commented Feb 2, 2022

Interestingly, I cannot access the link, can you? The website states permission issues.

@MakisH
Copy link
Member

MakisH commented Feb 2, 2022

Interestingly, I cannot access the link, can you? The website states permission issues.

I accessed both the issue tracker and the link to GitHub I posted just now.

Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@davidscn davidscn merged commit 88fb82e into precice:develop Feb 2, 2022
@davidscn davidscn deleted the fix-note branch February 2, 2022 09:24
@MakisH MakisH added this to the v202104.2.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants