Skip to content

Conversation

@MakisH
Copy link
Member

@MakisH MakisH commented Feb 8, 2022

This is a schduled release for the tutorials, in the context of the preCICE Distribution 202202.0.

I suggest that we drop the third version digit and have revisions starting from zero.

Notes on versioning after open discussion:

  • Three digits are too many for the tutorials
  • Since the VM is based on the tutorials, we can use the same system, with two digits in the tutorials, three digits in the VM (the third being the revision of the VM).
  • If we do a bugfix (e.g., only specific changes, not develop) in, e.g., April, we still name it 202202.1.

I will document this relation and strategy in the distribution page.

I will prepare the changelog and merge to master, but not release before testing the complete stack. We will directly test in the VM.

IshaanDesai and others added 30 commits May 24, 2021 20:28
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
Mohamad Altaweel and others added 17 commits January 2, 2022 15:26
* changed visualize to python 3

* removed backup file
…lculix (#250)

* Update all.msh, use C3D8I elements
* Update flap.inp, added `DIRECT` parameter to `*DYNAMIC* keyword.
* Fix note regarding residual control

* Apply suggestions from code review

Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>

Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
* Add PEP8 CI.

* Format code-base.

* Better formatting

* Increase line length to 120.

* Some more reformatting.

* Minor reformatting.

* More reformatting.

* Cleanup perpendicular flap.

* Partially update for turek-hron. BROKEN! #186

* Add missing file.

* Remove turek-hron FEniCS solver.

* Update broken run script for paritioned-heat-conduction-complex FEniCS case

* Making output folder structure consistent for all FEniCS participants

Co-authored-by: BenjaminRodenberg <benjamin.rodenberg@in.tum.de>
We anyway check that the tutorials run with the latest supported versions.
* Initial case setup

* Defining correct cylinder mesh

* Rectifying autopep8 violation

* Changing conditions to filter boudary nodes

* Removing debugging statements

* Correct fixed boundary filtering condition

Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@in.tum.de>

* Simplifying fixed boundary filter condition

* Port CalculiX configuration

* Updating README and adding watchpoint in config xml

* Reverting to DisplacementDelta data exchange and testing new implementation in FEniCS

* Add script for plotting watchpoints.

* Plot correct data and all three dimensions.

* Minor corrections

* Adding displacement plot to README

* Markdown stuff and renaming output folder

* Correct image name

Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@in.tum.de>
@MakisH MakisH self-assigned this Feb 8, 2022
@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Feb 8, 2022

I compared the OpenFOAM-Calculix and OpenFOAM-FEniCS results for the perpendicular flap and they look good. There is no visible regression. I plotted the REF results (based on the last distribution that we created for the latest version of the paper) and the RC results (using the most recent version of tutorials and adapters going into the distribution):

tutorials-perpendicular-flap-displacement-all-watchpoints

Software versions used:

29f27ec
precice/openfoam-adapter@e88aca1
precice/fenics-adapter@0e0ca92
precice/python-bindings@44b715d (a bit older, but should be fine 😏)
precice/precice@1c20fcc

@MakisH MakisH requested a review from davidscn February 8, 2022 16:16
@MakisH MakisH changed the title Release (version upcoming) Release v202202.0 Feb 9, 2022
@MakisH MakisH changed the title Release v202202.0 Release v2202.0 Feb 9, 2022
@MakisH MakisH changed the title Release v2202.0 Release v202202.0 Feb 9, 2022
@MakisH MakisH marked this pull request as ready for review February 9, 2022 11:57
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a few tutorial cases with different solver combinations and everything seems to be in order 👍

@MakisH
Copy link
Member Author

MakisH commented Feb 9, 2022

I ran a few tutorial cases with different solver combinations and everything seems to be in order +1

Thanks! Could you please list which cases you ran?

@MakisH MakisH merged commit 5acb330 into master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

7 participants