Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node: imports #476

Merged
merged 2 commits into from Jul 14, 2022
Merged

Fix node: imports #476

merged 2 commits into from Jul 14, 2022

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Jul 14, 2022

Closes #448

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

🦋 Changeset detected

Latest commit: 502904e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #476 (502904e) into main (4ce8cfc) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   92.02%   92.11%   +0.09%     
==========================================
  Files          32       32              
  Lines        1455     1459       +4     
  Branches      406      409       +3     
==========================================
+ Hits         1339     1344       +5     
+ Misses        111      110       -1     
  Partials        5        5              
Impacted Files Coverage Δ
packages/cli/src/build/rollup.ts 91.30% <100.00%> (+0.53%) ⬆️
packages/cli/src/build/config.ts 82.35% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce8cfc...502904e. Read the comment docs.

@emmatown emmatown merged commit 3930466 into main Jul 14, 2022
11 checks passed
@emmatown emmatown deleted the fix-node-builtin-imports branch Jul 14, 2022
@github-actions github-actions bot mentioned this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Node builtin modules results in "package is not specified in dependencies or peerDependencies" error
1 participant