Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unresolveable packages #481

Merged
merged 4 commits into from Jul 18, 2022

Conversation

efoken
Copy link
Contributor

@efoken efoken commented Jul 18, 2022

This PR fixes #480

I updated the @rollup/plugin-node-resolve plugin to make direct imports resolveable.

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2022

🦋 Changeset detected

Latest commit: 67b9559

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #481 (67b9559) into main (e9e8ec4) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   92.04%   92.18%   +0.13%     
==========================================
  Files          32       32              
  Lines        1459     1459              
  Branches      409      400       -9     
==========================================
+ Hits         1343     1345       +2     
+ Misses        111      109       -2     
  Partials        5        5              
Impacted Files Coverage Δ
packages/cli/src/build/rollup.ts 91.30% <100.00%> (ø)
packages/cli/src/validate-package.ts 95.45% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e8ec4...67b9559. Read the comment docs.

Copy link
Member

@emmatown emmatown left a comment

Thanks!

@emmatown emmatown merged commit 76f0163 into preconstruct:main Jul 18, 2022
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package is not specified in dependencies error for UMD builds
2 participants