Cache Validator documentation #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowin
reviewed
Aug 14, 2018
| @@ -88,6 +89,11 @@ def __init__( | |||
| self.trigger = trigger or prefect.triggers.all_successful | |||
| self.skip_on_upstream_skip = skip_on_upstream_skip | |||
|
|
|||
| if cache_for is None and cache_validator is not None: | |||
| warnings.warn( | |||
There was a problem hiding this comment.
In another PR you used from warnings import warn as _warn, which I liked and used elsewhere -- just curious if that was for a specific purpose not applicable here?
There was a problem hiding this comment.
Yea, I used that in executors.__init__.py so that, e.g., tab completion on prefect.engine.executors wouldn't display it. I usually treat __init__.py files as hallowed ground for imports for no real reason. Happy to do that here, too, to be consistent.
jlowin
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for cache validators + a new test / warning.