Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version field included in RegistrationRequest? #57

Open
justinmayer opened this issue Jun 19, 2017 · 2 comments
Open

Version field included in RegistrationRequest? #57

justinmayer opened this issue Jun 19, 2017 · 2 comments

Comments

@justinmayer
Copy link

When using this add-on with Firefox 52 to add a U2F device to the demo web application provided by django-u2f, an error is raised due to a missing required version field.

I filed an issue report in order to learn more about the error, and the django-u2f project author raised the question as to whether the U2F specification considers version to be a required field. As far as I can tell by looking at the specification, it appears that version is indeed intended to be a required field in the context of a RegistrationRequest: https://fidoalliance.org/specs/fido-u2f-v1.1-id-20160915/fido-u2f-javascript-api-v1.1-id-20160915.html#u2f-operations

If that is the case, I have two questions:

  1. Is this add-on not currently including a version field in its request when adding a device?
  2. If not, do you think a version field could be added to registration requests?
@justinmayer
Copy link
Author

Hi @prefiks. Do you think you could take a moment to share your thoughts regarding this issue?

@baloo
Copy link

baloo commented Jul 29, 2017

As far as I understand the code, the problem lies in the libu2f-host. It does not reply with the version.

prefiks added a commit that referenced this issue Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants