Deadlock at development server when using :host option #4

Closed
guiocavalcanti opened this Issue Oct 11, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@guiocavalcanti
Contributor

guiocavalcanti commented Oct 11, 2011

When passing base_url Premailer tries to fetch the CSS file from local development server, which has been blocked by processing the previous request. Once most of the development servers may process only one request at time, the whole process is being blocked until timeout.

More info at premailer issues.

@ndbroadbent

This comment has been minimized.

Show comment Hide comment
@ndbroadbent

ndbroadbent Oct 11, 2011

Owner

Oh yeah, I noticed that too. I think that was the reason why I didn't try passing base_url, but instead wrote the override to handle loading stylesheets from the filesystem

Owner

ndbroadbent commented Oct 11, 2011

Oh yeah, I noticed that too. I think that was the reason why I didn't try passing base_url, but instead wrote the override to handle loading stylesheets from the filesystem

@guiocavalcanti

This comment has been minimized.

Show comment Hide comment
@guiocavalcanti

guiocavalcanti Oct 11, 2011

Contributor

I've solved the problem with a two-phase conversion. The first one inlines the CSS using the filesystem stylesheet (premailer takes care of removing the <link> tag). The second one just prepends the base_url to the remaning hrefs, srcs and so on.

I know it's hacky but it works just fine. I guess. ;P

Contributor

guiocavalcanti commented Oct 11, 2011

I've solved the problem with a two-phase conversion. The first one inlines the CSS using the filesystem stylesheet (premailer takes care of removing the <link> tag). The second one just prepends the base_url to the remaning hrefs, srcs and so on.

I know it's hacky but it works just fine. I guess. ;P

@ndbroadbent

This comment has been minimized.

Show comment Hide comment
@ndbroadbent

ndbroadbent Oct 11, 2011

Owner

Solved with Pull Request #5. Works fine, but could be refactored later on.

Owner

ndbroadbent commented Oct 11, 2011

Solved with Pull Request #5. Works fine, but could be refactored later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment