New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor-specific attributes for table formatting #75

Merged
merged 1 commit into from Sep 7, 2011

Conversation

Projects
None yet
4 participants
@der-flo
Contributor

der-flo commented Aug 31, 2011

I introduced some more attribute mappings in order to be able to set
some table-specific attributes via CSS.

What do you think about this solution? Do you have a better idea? Should we replace the 'premailer' prefix with 'html' etc.?

If needed I can give the code some more love and DRY it up.

Vendor-specific attribute for table formatting
I introduced some more attribute mappings in order to be able to set
some table-specific attributes via CSS.
@svenwin

This comment has been minimized.

Show comment
Hide comment
@svenwin

svenwin commented Sep 1, 2011

+1

@danielbayerlein

This comment has been minimized.

Show comment
Hide comment
@danielbayerlein

danielbayerlein commented Sep 1, 2011

+1

@alexdunae

This comment has been minimized.

Show comment
Hide comment
@alexdunae

alexdunae Sep 7, 2011

Contributor

Totally cool. Great solution.

Contributor

alexdunae commented Sep 7, 2011

Totally cool. Great solution.

alexdunae added a commit that referenced this pull request Sep 7, 2011

Merge pull request #75 from Nix-wie-weg/master
Vendor-specific attributes for table formatting

@alexdunae alexdunae merged commit 358152c into premailer:master Sep 7, 2011

@alexdunae

This comment has been minimized.

Show comment
Hide comment
@alexdunae

alexdunae Sep 7, 2011

Contributor

Curious about the inclusion of colspan on the TD (but not the TH). What's the use case for needing to set the colspan in CSS? And why not rowspan?

Contributor

alexdunae commented Sep 7, 2011

Curious about the inclusion of colspan on the TD (but not the TH). What's the use case for needing to set the colspan in CSS? And why not rowspan?

@der-flo

This comment has been minimized.

Show comment
Hide comment
@der-flo

der-flo Sep 16, 2011

Contributor

@alexdunae:
My patch is simply not complete/correct concerning colspan and rowspan. Of course I could do that. But the question regarding the use case is legitimate. colspan is not a formatting option but really semantic. So colspan attributes should be left in the HTML, right?

I will fix that next week when I'm back from my vacation.

Contributor

der-flo commented Sep 16, 2011

@alexdunae:
My patch is simply not complete/correct concerning colspan and rowspan. Of course I could do that. But the question regarding the use case is legitimate. colspan is not a formatting option but really semantic. So colspan attributes should be left in the HTML, right?

I will fix that next week when I'm back from my vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment