From 83f3b4491317a08633d16779ab2a7e7d83392677 Mon Sep 17 00:00:00 2001 From: Shubham Date: Tue, 21 Mar 2023 05:44:48 +0000 Subject: [PATCH] [CLOUDGA-12309] Populate providerCode in regions/az even when config is null Summary: [CLOUDGA-12309] Populate providerCode in regions/az in case config is null. YBM as part of edit provider call removes `config` from the GET request. Because of which we are not setting `providerCode` in regions/azs to support backward compatiblity. This diff removes that check & set `providerCode` for the new regions/zones added. Test Plan: Manually verified the payload YBM passes. Reviewers: yshchetinin, sb-yb Reviewed By: sb-yb Subscribers: yugaware Differential Revision: https://phabricator.dev.yugabyte.com/D23773 --- .../yugabyte/yw/controllers/CloudProviderApiController.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/managed/src/main/java/com/yugabyte/yw/controllers/CloudProviderApiController.java b/managed/src/main/java/com/yugabyte/yw/controllers/CloudProviderApiController.java index 45bc5c3d86055..4ee3ef9f5566e 100644 --- a/managed/src/main/java/com/yugabyte/yw/controllers/CloudProviderApiController.java +++ b/managed/src/main/java/com/yugabyte/yw/controllers/CloudProviderApiController.java @@ -343,10 +343,7 @@ public Result editAccessKeyRotationSchedule( // v2 API version 1 backward compatiblity support. public JsonNode mayBeMassageRequest(JsonNode requestBody, Boolean forEdit) { JsonNode config = requestBody.get("config"); - if (config == null) { - return requestBody; - } - if (forEdit) { + if (forEdit && config != null) { ((ObjectNode) requestBody).remove("config"); } String providerCode = requestBody.get("code").asText();