Improve compatibility with Node.js v6.0.0

[jackhsu978]

querystring in node v6 now returns an "empty" object instead of {}, causing an error: “TypeError: parsedQuery.hasOwnProperty is not a function”. Instead calling hasOwnProperty on parsedQuery, just check parsedQuery['_escaped_fragment_'] instead, as suggested by @thoop

[thoop]

Weird I wouldn't expect those tests to fail just because of that change. I'll have to look into this unless you have any ideas what caused that.

[jackhsu978]

@thoop I don't know why either. I ran npm test locally and everything is passing.

[jackhsu978]

@thoop I forgot about the case where the parameter _escaped_fragment_ is an empty string. should be fixed.

[mscdex]

The alternative fix is to use something like this:

function hasOwnProperty(obj, prop) {
  return Object.prototype.hasOwnProperty.call(obj, prop);
}

// Then use like:
hasOwnProperty(parsedQuery, '_escaped_fragment_')

which is "safer" since hasOwnProperty() (or any other inherited property) on objects can be overridden anyway.

[thoop]

I don't think we ever want to look up the chain for _escaped_fragment_ so this fix should work fine.

[jackhsu978]

@thoop Do you mind merging this? Please let me know if there is any other change that you'd like to see and I will be happy to tweak.

[thoop]

Sorry! Been really busy this week. I'll merge it this weekend.

[thoop]

Thanks for your help!

[jackhsu978]

Thank you for the merge @thoop! 👍