v2.0.0-beta.14 #316
Merged
v2.0.0-beta.14 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it to undefined (#313) REMOVE action removes deep property instead of setting it to undefined
* Docs updated with notes about `remove` and `dispatchRemoveAction`
Codecov Report
@@ Coverage Diff @@
## v2.0.0 #316 +/- ##
=========================================
- Coverage 84.11% 83.6% -0.52%
=========================================
Files 22 22
Lines 2090 2122 +32
Branches 324 329 +5
=========================================
+ Hits 1758 1774 +16
- Misses 332 348 +16 |
prescottprue
added a commit
that referenced
this pull request
Oct 29, 2017
* fix(typings): Updated type definitions - #311 * fix(populate): dispatch for errors during profile population - #312 * feat(firebaseConnect): `store` is passed as second argument of `firebaseConnect` - #278 * feat(firestoreConnect): `store` is passed as second argument of `firestoreConnect` * fix(query): `dispatchRemoveAction` is now `false` by default - prevents multiple state updates when calling `remove` if listener associated is attached * `store` being passed as second argument of `firebaseConnect` (and `firestoreConnect`), which means any components using that second argument will break (most commonly used for getting `uid`). To access `uid` or other info from redux state, use `store.getState()` like so: ```js firebaseConnect( (props, store) => { const { firebase: { auth } } = store.getState() // be careful, listeners are not re-attached when auth state changes unless props change return [{ path: `todos/${auth.uid || ''}` }] } ) ``` More details are included in [the migration guide](http://docs.react-redux-firebase.com/history/v2.0.0/docs/v2-migration-guide.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
storeis passed as second argument offirebaseConnect- feat(database): access store state within firebaseConnect #278storeis passed as second argument offirestoreConnectdispatchRemoveActionis nowfalseby default - prevents multiple state updates when callingremoveif listener associated is attachedPotentially Breaking
storebeing passed as second argument offirebaseConnect(andfirestoreConnect), which means any components using that second argument will break (most commonly used for gettinguid). To accessuidor other info from redux state, usestore.getState()like so:More details are included in the migration guide.
Check List
If not relevant to pull request, check off as complete
Relevant Issues