New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on redirect_to + strong parameters #1000

Closed
JasonBarnabe opened this Issue Feb 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@JasonBarnabe
Contributor

JasonBarnabe commented Feb 18, 2017

redirect_to params.permit(:page, :per_page, :site, :sort, :q), status: 301

gives Possible unprotected redirect. As long as the whitelisted parameters aren't one of the special ones, this is fine, right?

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Feb 18, 2017

Owner

#1000! 🎉

Yes, I agree this is safe and can be fixed.

Owner

presidentbeef commented Feb 18, 2017

#1000! 🎉

Yes, I agree this is safe and can be fixed.

@presidentbeef presidentbeef added this to the 4.0.2 milestone Nov 17, 2017

presidentbeef added a commit that referenced this issue Nov 17, 2017

Repository owner locked and limited conversation to collaborators Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.