New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render dangerous cookies #1090

Closed
slayer opened this Issue Sep 4, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@slayer

slayer commented Sep 4, 2017

I have found serious vulnerability in my unreleased code:

   render inline: request.cookies["somecookie"]

It will be great to add checking for that case.
Thanks

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Sep 5, 2017

Owner

Hi Vlad,

Brakeman does check for this type of vulnerability, but it doesn't currently recognize request.cookies. If you changed it to

   render inline: cookies["somecookie"]

you would see a warning.

Owner

presidentbeef commented Sep 5, 2017

Hi Vlad,

Brakeman does check for this type of vulnerability, but it doesn't currently recognize request.cookies. If you changed it to

   render inline: cookies["somecookie"]

you would see a warning.

@slayer

This comment has been minimized.

Show comment
Hide comment
@slayer

slayer commented Sep 5, 2017

Thanks

@slayer slayer closed this Sep 5, 2017

presidentbeef added a commit that referenced this issue Sep 6, 2017

Repository owner locked and limited conversation to collaborators Oct 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.