New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`symbolize_keys` check gets confused on safe (?) model lookup #1096

Closed
AndrewRayCode opened this Issue Sep 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@AndrewRayCode

AndrewRayCode commented Sep 18, 2017

A line like this:

Model.find(safe_params[:id]).attributes.symbolize_keys

Seems to confuse brakeman. It's creating keys out of model attributes, not user input.

I tried to make a one-off test case file for this but I realized brakeman looks for a whole Rails application.

@presidentbeef

This comment has been minimized.

Owner

presidentbeef commented Nov 3, 2017

I agree. Will fix...my first attempt didn't work out.

@presidentbeef presidentbeef added this to the 4.0.2 milestone Nov 17, 2017

presidentbeef added a commit that referenced this issue Feb 21, 2018

Repository owner locked and limited conversation to collaborators May 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.