hangs on Indexing call sites... #171

Closed
jpwynn opened this Issue Oct 26, 2012 · 9 comments

Comments

Projects
None yet
3 participants
@jpwynn

jpwynn commented Oct 26, 2012

Most of my apps, it runs quickly ( a minute or so) but a larger app (8000 LOC) it just hands when it gets to indexing call sites.

Even running with -d that's the last message shown ("Indexing call sites... "). --fast had no effect.

Any thoughts on how I can figure out what's causing it to hang?

My ruby is ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-linux], the app is a rails 3.0.17.

@jpwynn

This comment has been minimized.

Show comment
Hide comment
@jpwynn

jpwynn Oct 26, 2012

never mind - came back 2 hours later and it had finished.

jpwynn commented Oct 26, 2012

never mind - came back 2 hours later and it had finished.

@jpwynn jpwynn closed this Oct 26, 2012

@oreoshake

This comment has been minimized.

Show comment
Hide comment
@oreoshake

oreoshake Oct 26, 2012

Contributor

Wait, that's not a "nevermimind" IMO. 2 hours is way above the unofficial
sla
On Oct 25, 2012 9:04 PM, "JP Wynn" notifications@github.com wrote:

never mind - came back 2 hours later and it had finished.


Reply to this email directly or view it on GitHubhttps://github.com/presidentbeef/brakeman/issues/171#issuecomment-9800917.

Contributor

oreoshake commented Oct 26, 2012

Wait, that's not a "nevermimind" IMO. 2 hours is way above the unofficial
sla
On Oct 25, 2012 9:04 PM, "JP Wynn" notifications@github.com wrote:

never mind - came back 2 hours later and it had finished.


Reply to this email directly or view it on GitHubhttps://github.com/presidentbeef/brakeman/issues/171#issuecomment-9800917.

@presidentbeef presidentbeef reopened this Oct 26, 2012

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Oct 26, 2012

Owner

Hi JP,

Any idea how long it actually took?

Unfortunately, hanging at "indexing call sites" is probably not going to go any faster, especially if your 8000 lines of code is mostly in the models, controllers, and views (i.e., code that matters). But, there could still possibly be a bug in Brakeman.

Owner

presidentbeef commented Oct 26, 2012

Hi JP,

Any idea how long it actually took?

Unfortunately, hanging at "indexing call sites" is probably not going to go any faster, especially if your 8000 lines of code is mostly in the models, controllers, and views (i.e., code that matters). But, there could still possibly be a bug in Brakeman.

@jpwynn

This comment has been minimized.

Show comment
Hide comment
@jpwynn

jpwynn Oct 26, 2012

I'll try to measure it and report back... not saying it took 2 hours... I let it run maybe 20 minutes, aborted, tried again, and after 20 minutes or so put the note on github. When I came back 2 hours later it had completed... so could have been anywhere from 21 minutes to 2 hours. Since next next-largest app took a minute or two I figured it had hung. FWIW it was a legacy app that had:

Controllers     27
Models  17
Templates   222
Errors  5
Security Warnings   105

jpwynn commented Oct 26, 2012

I'll try to measure it and report back... not saying it took 2 hours... I let it run maybe 20 minutes, aborted, tried again, and after 20 minutes or so put the note on github. When I came back 2 hours later it had completed... so could have been anywhere from 21 minutes to 2 hours. Since next next-largest app took a minute or two I figured it had hung. FWIW it was a legacy app that had:

Controllers     27
Models  17
Templates   222
Errors  5
Security Warnings   105
@jpwynn

This comment has been minimized.

Show comment
Hide comment
@jpwynn

jpwynn Oct 26, 2012

It took 78 minutes

jpwynn commented Oct 26, 2012

It took 78 minutes

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Oct 27, 2012

Owner

Yeah, that's a long time. I'm not sure what can be done about it, but I'll take a look. Thanks!

Owner

presidentbeef commented Oct 27, 2012

Yeah, that's a long time. I'm not sure what can be done about it, but I'll take a look. Thanks!

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Nov 13, 2012

Owner

Hi JP,

Can you try again with Brakeman 1.8.3? Thanks!

Owner

presidentbeef commented Nov 13, 2012

Hi JP,

Can you try again with Brakeman 1.8.3? Thanks!

@jpwynn

This comment has been minimized.

Show comment
Hide comment
@jpwynn

jpwynn Nov 13, 2012

Congratulations! It took 40 seconds in 1.8.3 (vs 78 minutes in 1.8.2).

jpwynn commented Nov 13, 2012

Congratulations! It took 40 seconds in 1.8.3 (vs 78 minutes in 1.8.2).

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Nov 13, 2012

Owner

:bowtie: That is awesome!

Owner

presidentbeef commented Nov 13, 2012

:bowtie: That is awesome!

Repository owner locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.