New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new text output format #914

Closed
presidentbeef opened this Issue Jul 27, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@presidentbeef
Owner

presidentbeef commented Jul 27, 2016

The current tables output is a little restrictive and often runs off the screen, hiding information. Outputting to a file is ugly.

Proposal

Phase in a new text output format closer to what bundler-audit or brakeman -I shows (with colors of course).

Example:

Confidence: High
Category: Dangerous Eval
Message: User input in eval
Code: eval(params[:dangerous_input])
File: app/controllers/home_controller.rb
Line: 40

4.0

In 4.0 this would become the default output. The table format would still be available.

/cc @grosser @gbirchmeier

@presidentbeef presidentbeef added the 4.0 label Jul 27, 2016

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Jul 27, 2016

Contributor

👍 for nice defaults :)

Contributor

grosser commented Jul 27, 2016

👍 for nice defaults :)

@gbirchmeier

This comment has been minimized.

Show comment
Hide comment
@gbirchmeier

gbirchmeier Jul 27, 2016

It took me a while to figure out why you cc'd me -- #562 😄

Any output that is independent of terminal-width is good by me 👍

gbirchmeier commented Jul 27, 2016

It took me a while to figure out why you cc'd me -- #562 😄

Any output that is independent of terminal-width is good by me 👍

@schnedio

This comment has been minimized.

Show comment
Hide comment
@schnedio

schnedio Aug 18, 2016

Great news! 👍

schnedio commented Aug 18, 2016

Great news! 👍

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Sep 6, 2016

Owner

First cut of this in #935

Owner

presidentbeef commented Sep 6, 2016

First cut of this in #935

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Jul 1, 2017

Owner

No one has complained about or provided suggestions for -f plain which implements this. (I still plan on making it the default in 4.0).

Owner

presidentbeef commented Jul 1, 2017

No one has complained about or provided suggestions for -f plain which implements this. (I still plan on making it the default in 4.0).

Repository owner locked and limited conversation to collaborators Aug 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.