New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CheckSymbolDos if ruby_version > 2.2 #928

Closed
mintuhouse opened this Issue Aug 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@mintuhouse

mintuhouse commented Aug 26, 2016

https://github.com/presidentbeef/brakeman/blob/master/lib/brakeman/checks/check_symbol_dos.rb
Currently this is checking for Rails 5 for which 2.2 is required

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Aug 28, 2016

Owner

Sure, no problem.

You can also exclude the check with -x CheckSymbolDoS.

Owner

presidentbeef commented Aug 28, 2016

Sure, no problem.

You can also exclude the check with -x CheckSymbolDoS.

presidentbeef added a commit that referenced this issue Oct 15, 2016

Attempt to get and use Ruby version from app
either .ruby-version or Gemfile

Closes #928

presidentbeef added a commit that referenced this issue Oct 15, 2016

Attempt to get and use Ruby version from app
either .ruby-version or Gemfile

Closes #928

presidentbeef added a commit that referenced this issue Oct 15, 2016

Attempt to get and use Ruby version from app
either .ruby-version or Gemfile

Closes #928

Repository owner locked and limited conversation to collaborators Mar 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.