New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_cross_site_scripting flags Environment Variables as unsafe #939

Closed
JPrevost opened this Issue Sep 28, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@JPrevost

JPrevost commented Sep 28, 2016

I've got code like:

<%= link_to("Thing", "#{ENV['SOME_URL']}") %>

Brakeman flags that as unsafe. That's not coming from a user, but a server admin.

Thoughts on whether this could be detected by brakeman as safe? Thanks!

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Sep 28, 2016

Owner

Hi Jeremy,

I cannot reproduce this issue. I am fairly certain Brakeman does not warn about ENV. Can you share more about the warning?

Owner

presidentbeef commented Sep 28, 2016

Hi Jeremy,

I cannot reproduce this issue. I am fairly certain Brakeman does not warn about ENV. Can you share more about the warning?

@JPrevost

This comment has been minimized.

Show comment
Hide comment
@JPrevost

This comment has been minimized.

Show comment
Hide comment
@JPrevost

JPrevost Sep 28, 2016

Also, I don't mind doing the legwork on this but wanted to ask for guidance before digging in :)

Thanks!

JPrevost commented Sep 28, 2016

Also, I don't mind doing the legwork on this but wanted to ask for guidance before digging in :)

Thanks!

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Sep 29, 2016

Owner

Ah, yes it's warning about params[:q]. This will be fixed in #940

Owner

presidentbeef commented Sep 29, 2016

Ah, yes it's warning about params[:q]. This will be fixed in #940

Repository owner locked and limited conversation to collaborators Feb 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.